Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework OTel exporter API and documentation #41705

Merged
merged 53 commits into from
Sep 20, 2024
Merged

Rework OTel exporter API and documentation #41705

merged 53 commits into from
Sep 20, 2024

Conversation

jeanbisutti
Copy link
Contributor

No description provided.

@jeanbisutti jeanbisutti marked this pull request as draft September 3, 2024 13:57
@github-actions github-actions bot added the OpenTelemetry OpenTelemetry instrumentation label Sep 3, 2024
@jeanbisutti
Copy link
Contributor Author

cc @lmolkova

@azure-sdk
Copy link
Collaborator

azure-sdk commented Sep 3, 2024 •
edited
Loading

API change check

API changes are not detected in this pull request.

@jeanbisutti jeanbisutti force-pushed the jean/rework-otel-exporter-api-doc branch from d4d3bb7 to 4fc4fc9 Compare September 4, 2024 12:10
@jeanbisutti jeanbisutti force-pushed the jean/rework-otel-exporter-api-doc branch from 810782d to c3bb22d Compare September 4, 2024 15:59
@jeanbisutti
Copy link
Contributor Author

@lmolkova

AzureMonitor provides a high-level API to enable Azure Monitor for OpenTelemetry autoconfiguration:

AutoConfiguredOpenTelemetrySdkBuilder sdkBuilder = AutoConfiguredOpenTelemetrySdk.builder();

OpenTelemetry openTelemetry = new AzureMonitor().connectionString("{connection-string}")
                                      .configure(sdkBuilder).build().getOpenTelemetrySdk();

We expect that most users will use the OpenTelemetry autoconfiguration.

AzureMonitorExporterBuilder provides a low-level API to create OpenTelemetry span, log record and metric exporters for Azure.

There is a CI compilation issue with TelemetryHelper. It seems that the CI compiles this class for the OpenTelemetry exporter 1.0.0-beta.28, but also with the exporter version of the main branch. The exporter API of the main branch has changed, leading to a compilation failure. Any help to be able to fix this CI issue would be appreciated.

@jeanbisutti jeanbisutti marked this pull request as ready for review September 5, 2024 14:28
@jeanbisutti jeanbisutti force-pushed the jean/rework-otel-exporter-api-doc branch 2 times, most recently from 2aaf035 to 43d215b Compare September 11, 2024 12:05
@jeanbisutti jeanbisutti force-pushed the jean/rework-otel-exporter-api-doc branch from a590ee5 to db7b4f0 Compare September 16, 2024 09:54
jeanbisutti and others added 23 commits September 20, 2024 15:09
@jeanbisutti
AzureMonitor now uses the AutoConfigurationCustomizer interface
9028e57
@jeanbisutti
Remove methods without a ConfigProperties argument in AzureMonitorExp…
35e2a5f 
…orterBuilder
@jeanbisutti
Remove empty line
14262fd
@jeanbisutti
Remove unused import
a45ec2c
@jeanbisutti
Update Hjavadoc of the HttpTrait methods
dc3528b
@jeanbisutti
configure method name renamed to customize, to look like https://gith…
b5f50f8 
…ub.com/open-telemetry/opentelemetry-java/blob/main/sdk-extensions/autoconfigure-spi/src/main/java/io/opentelemetry/sdk/autoconfigure/spi/AutoConfigurationCustomizerProvider.java
@jeanbisutti @trask
Update sdk/monitor/azure-monitor-opentelemetry-exporter/README.md
718ccac 
Co-authored-by: Trask Stalnaker <[email protected]>
@jeanbisutti @trask
Update eng/code-quality-reports/src/main/resources/checkstyle/checkst…
68ad45d 
…yle-suppressions.xml

Co-authored-by: Trask Stalnaker <[email protected]>
@jeanbisutti @trask
Update sdk/monitor/azure-monitor-opentelemetry-exporter/README.md
87d4c5b 
Co-authored-by: Trask Stalnaker <[email protected]>
@jeanbisutti @trask
Update sdk/monitor/azure-monitor-opentelemetry-exporter/README.md
2542a2b 
Co-authored-by: Trask Stalnaker <[email protected]>
@jeanbisutti @trask
Update sdk/monitor/azure-monitor-opentelemetry-exporter/README.md
44baff8 
Co-authored-by: Trask Stalnaker <[email protected]>
@jeanbisutti
Remove star import
4bc5cf2
@jeanbisutti
Use constant for attribute key
9f3e674
@jeanbisutti
Fix ReadmeSamples.java:[128,55] Illegal static declaration in inner c…
993e554 
…lass
@jeanbisutti
Try to fix code snippet issue
92ef3f5
@jeanbisutti
spotless
51d6774
@jeanbisutti
Fix
4edb2c9
@jeanbisutti
Remove retryPolicy method
afe3c1c
@jeanbisutti
spotless
939490c
@jeanbisutti
Fix Javadoc
edfedfe
@jeanbisutti
Bump some projects to the last exporter version to make them compile
2a3636a
@jeanbisutti
Add unreleased to version_client.txt
28050d3
@jeanbisutti
Update checkstyle-suppressions after having rebased
f335fa0
@jeanbisutti jeanbisutti force-pushed the jean/rework-otel-exporter-api-doc branch from 35ee2d2 to f335fa0 Compare September 20, 2024 13:23
@alzimmermsft
Copy link
Member

/check-enforcer override

@alzimmermsft alzimmermsft merged commit d27c57c into main Sep 20, 2024
95 of 103 checks passed
@alzimmermsft alzimmermsft deleted the jean/rework-otel-exporter-api-doc branch September 20, 2024 14:47
@heyams heyams mentioned this pull request Sep 30, 2024
Merged
mssfang pushed a commit to mssfang/azure-sdk-for-java that referenced this pull request Oct 21, 2024
@jeanbisutti @mssfang
Rework OTel exporter API and documentation (Azure#41705)
9d58f13 
Rework OTel exporter API and documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmolkova lmolkova lmolkova approved these changes

@heyams heyams heyams left review comments

@trask trask trask approved these changes

@alzimmermsft alzimmermsft alzimmermsft approved these changes

@srnagar srnagar srnagar approved these changes

@ramthi ramthi Awaiting requested review from ramthi ramthi is a code owner

@harsimar harsimar Awaiting requested review from harsimar harsimar is a code owner

@mssfang mssfang Awaiting requested review from mssfang mssfang is a code owner

@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles JonathanGiles is a code owner

@rujche rujche Awaiting requested review from rujche rujche is a code owner

@Netyyyy Netyyyy Awaiting requested review from Netyyyy Netyyyy is a code owner

@saragluna saragluna Awaiting requested review from saragluna saragluna is a code owner

@moarychan moarychan Awaiting requested review from moarychan moarychan is a code owner

@hallipr hallipr Awaiting requested review from hallipr hallipr is a code owner

@weshaggard weshaggard Awaiting requested review from weshaggard weshaggard is a code owner

@JimSuplizio JimSuplizio Awaiting requested review from JimSuplizio JimSuplizio is a code owner

@anuchandy anuchandy Awaiting requested review from anuchandy anuchandy is a code owner

@conniey conniey Awaiting requested review from conniey conniey is a code owner

Assignees
No one assigned
Labels
OpenTelemetry OpenTelemetry instrumentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jeanbisutti @azure-sdk @alzimmermsft @trask @lmolkova @srnagar @heyams